Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32017 )
Change subject: mb/google/hatch: Enable FP MCU
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32017/2/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/32017/2/src/mainboard/google/hatch/variants/...
PS2, Line 305: GPE0_DW0_23
Doesn't this cause failures to enter S0ix since GPP_A23 is not configured with INVERT?
I did not verify S0ix, but you are probably correct. But as we only have 1 gpio for FPMCU_PCH_INT_ODL, this means that we'll have to disable wake on FP until the ITSS bug is fixed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32017
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2eba205d5e63664dca684fbd849454c5a2fe0d0e
Gerrit-Change-Number: 32017
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nicolas Norvez
norvez@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 21 Mar 2019 20:08:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment