Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44672 )
Change subject: drivers/wifi: load wifi_sar_defaults.hex as the main WiFi SAR CBFS source ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44672/1/src/drivers/wifi/generic/Kc... File src/drivers/wifi/generic/Kconfig:
https://review.coreboot.org/c/coreboot/+/44672/1/src/drivers/wifi/generic/Kc... PS1, Line 50: config WIFI_SAR_CBFS_FILENAME
drop this Kconfig.
Done
https://review.coreboot.org/c/coreboot/+/44672/1/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/sar.c:
https://review.coreboot.org/c/coreboot/+/44672/1/src/vendorcode/google/chrom... PS1, Line 116: return CONFIG_WIFI_SAR_CBFS_FILENAME;
I was suggesting we should return WIFI_SAR_CBFS_FILENAME here.
Done