Attention is currently required from: Jakub Czapiga, Jędrzej Ciupis, Matt DeVillier, Paul Menzel.
Subrata Banik has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84359?usp=email )
Change subject: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/84359/comment/f59d1115_f3682589?usp... : PS1, Line 39: select SOC_INTEL_CRASHLOG
that doesn't help, since `MAINBOARD_HAS_CHROMEOS` is already selected above -- it would enable it even for non-ChromeOS builds, just like it already is.
ummm, can you move the below code into JSL SoC Kconfig in that way, it might help you ?
``` select SOC_INTEL_CRASHLOG if MAINBOARD_HAS_CHROMEOS ```
``` src/soc/intel/pantherlake/Kconfig:87: select SOC_INTEL_CRASHLOG src/soc/intel/meteorlake/Kconfig:93: select SOC_INTEL_CRASHLOG ```
I will cleanup for Alder lake and Raptor Lake device today (moving crashlog from mainboard to SOC Kconfig). If you want, you can move the same for Jasper Lake or you want me to do that (to cover dedede) ?
``` src/mainboard/google/brya/Kconfig:47: select SOC_INTEL_CRASHLOG src/mainboard/google/brya/Kconfig:178: select SOC_INTEL_CRASHLOG src/mainboard/google/brya/Kconfig:188: select SOC_INTEL_CRASHLOG src/mainboard/google/dedede/Kconfig:39: select SOC_INTEL_CRASHLOG src/mainboard/google/brox/Kconfig:40: select SOC_INTEL_CRASHLOG src/mainboard/google/brox/Kconfig:52: select SOC_INTEL_CRASHLOG ```