Attention is currently required from: Angel Pons, Arthur Heymans, Eric Lai, Felix Held, Jeff Li, Johnny Lin, Jonathan Zhang, Martin L Roth, Martin Roth, Nico Huber, Nill Ge, Paul Menzel, Subrata Banik, TangYiwei, Ziang Wang, niehaitao@bytedance.com.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75737?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: arch/x86/smbios: Add a config string for BIOS Vendor in SMBIOS Type 0
......................................................................
Patch Set 4:
(3 comments)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/75737/comment/dd7b3d9d_ef02affd :
PS2, Line 894: BIOS_VENDOR
I don't see why. Type 0 is not about the mainboard.
The other attributes and methods related to the type0 table don't start with MAINBOARD_ as well. So I also prefer to remove the MAINBOARD_ prefix.
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/75737/comment/ff843bfb_ecd0bc18 :
PS4, Line 895: string
: prompt "SMBIOS BIOS Vendor string"
To align with the style of the other options below, please write like it like this.
```
prompt "SMBIOS BIOS Vendor"
string
```
https://review.coreboot.org/c/coreboot/+/75737/comment/8996a2b7_c6e8ca12 :
PS4, Line 899: string
Same here, please remove.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75737?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6dfcca338ffc48b150c966b9aefcefe928704d24
Gerrit-Change-Number: 75737
Gerrit-PatchSet: 4
Gerrit-Owner: TangYiwei
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jeff Li
lijinfeng01@inspur.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: niehaitao@bytedance.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: TangYiwei
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: niehaitao@bytedance.com
Gerrit-Attention: Ziang Wang
ziang.wang@intel.com
Gerrit-Attention: Jeff Li
lijinfeng01@inspur.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 21 Jun 2023 09:57:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Comment-In-Reply-To: TangYiwei
Gerrit-MessageType: comment