Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42062 )
Change subject: src/*: Update makefiles to exclude x86 code from non-x86 verstage
......................................................................
Patch Set 2:
This is going to become a maintenance burden longterm, cluttering Makefiles with preprocessor use. Please file a new bug if you decide to submit this in the shape of patchset #2. I think somwone really has to revisit the build-classes generator to properly support stages running on different arch.
You guarded selected verstage-y under cpu/x86 but you should guard them all. Like drivers/uart too that contains both PCI configuration and IO accesses.
Also picasso/tsc_freq.c is clearly x86-only and does not belong to verstage then.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42062
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I797b67394825172bd44ad1ee693a0c509289486b
Gerrit-Change-Number: 42062
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 05 Jun 2020 09:26:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment