[coreboot-gerrit] Change in coreboot[master]: nb/intel/nehalem: Add a VBOOT TPM init workaround

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36027 )

Change subject: nb/intel/nehalem: Add a VBOOT TPM init workaround
......................................................................

Patch Set 5:

(1 comment)
> Patch Set 5:
>
> (1 comment)
>
> Something similar is needed for Intel TXT boot, as the TPM is initialized before CPU reset. Is there a way to make it less platform specific?
> @Google What do you think about this?

If there is a way to probe if the TPM is already initialized I'm all ears. I could rename the Kconfig hook to something like VBOOT_TPM_POSSIBLY_INITIALIZED with a hook 'int is_tpm_initialized(void)' ?

https://review.coreboot.org/c/coreboot/+/36027/5/src/northbridge/intel/nehal... 
File src/northbridge/intel/nehalem/bootblock.c:

https://review.coreboot.org/c/coreboot/+/36027/5/src/northbridge/intel/nehal... 
PS5, Line 23: 	pci_write_config32(PCI_DEV(0, 0x00, 0), MCHBAR, (uintptr_t)DEFAULT_MCHBAR | 1);
> mention why it's done here

Ok.