Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36845 )
Change subject: security/vboot: Remove selected_region from struct vboot_working_data
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36845/4/src/security/vboot/vboot_lo...
File src/security/vboot/vboot_loader.c:
https://review.coreboot.org/c/coreboot/+/36845/4/src/security/vboot/vboot_lo...
PS4, Line 88: if (!vboot_locate_firmware(ctx, &fw_main))
This return value check is wrong. 0 is successful. I'll fix this up in the rebase.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36845
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27cb1a2175beb189053fc3e44b17b60aba474bb0
Gerrit-Change-Number: 36845
Gerrit-PatchSet: 4
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 19 Nov 2019 15:40:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment