Attention is currently required from: Arthur Heymans, Nico Huber. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58603 )
Change subject: [RFC]cpu/x86/mp_init.c: Copy BSP chip_info to AP devices ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58603/comment/09ecf417_22b66aff PS1, Line 9: few : workarounds like storing the BSP chip_info in a global variable or : using a fake lapic device would become obsolete Can you point me to some examples?
Patchset:
PS1:
Sorry, tried to review this, but the cpu_info() function starts with a […]
Yeah, I think you are right. I just didn't trust it. It felt like a brittle hack to me so I didn't want to touch it. IMO, it should be using __builtin_frame_address(0). All MP_INIT boards are using CPU_INFO_V2 now.
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/58603/comment/c44dc5e4_ed717e66 PS1, Line 392: new->chip_info = info->cpu->chip_info; Is it possible for `new->chip_info` to be already set if it was defined in the device tree?