Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31887 )
Change subject: vboot: make vboot workbuf available to payload ......................................................................
Patch Set 9: Code-Review+1
(4 comments)
https://review.coreboot.org/#/c/31887/1/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/#/c/31887/1/src/lib/coreboot_table.c@46 PS1, Line 46: #if CONFIG(VBOOT)
Yes, a lot of this code is quite old and we wouldn't write it like that anymore today.
Ack
https://review.coreboot.org/#/c/31887/5/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/#/c/31887/5/src/lib/coreboot_table.c@212 PS5, Line 212: #if CONFIG(VBOOT)
No, I think you misunderstand. […]
I indeed did misunderstand. But sounds like we can just remove the guards and leave as is.
https://review.coreboot.org/#/c/31887/8/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/#/c/31887/8/src/lib/coreboot_table.c@234 PS8, Line 234: if (wd == NULL)
nit: this can't really return NULL anyway.
Done
https://review.coreboot.org/#/c/31887/8/src/lib/coreboot_table.c@553 PS8, Line 553: lb_vboot_handoff(head);
Okay, sorry, now you have to move this into the block below after all to get around the unused funct […]
¯_(ツ)_/¯