[coreboot-gerrit] [M] Change in coreboot[main]: util/autoport: Extend Add_gpl to more files

[Angel Pons (Code Review)]

Attention is currently required from: Nicholas Chin.

Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83184?usp=email )

Change subject: util/autoport: Extend Add_gpl to more files
......................................................................

Patch Set 3:

(2 comments)

File util/autoport/main.go:

https://review.coreboot.org/c/coreboot/+/83184/comment/7efbf6bc_14cb57a6?usp... :
PS2, Line 882: 		gma.WriteString(`-- SPDX-License-Identifier: GPL-2.0-or-later
> I kind of do, because consistency: pretty much every `gma-mainboard.ads` uses `GPL-2.0-or-later` […]

Of course, the function would be renamed to `Add_License` or similar. CB:83185 would also be able to make use of it:

```
func Add_CC_PDDC(f *os.File, filetype Filetype) {
    Add_License(f, filetype, CC_PDDC)
    fmt.Fprintln(f)
    fmt.Fprintf(f, CommentFormatStrings[filetype],
    	"Please update the license if adding licensable material.")
}
```

https://review.coreboot.org/c/coreboot/+/83184/comment/3109ab8b_184f789c?usp... :
PS2, Line 232: func Add_gpl(f *os.File, filetype Filetype) {
             : 	fmt.Fprintf(f, CommentFormatStrings[filetype],
             : 		"SPDX-License-Identifier: GPL-2.0-only")
             : 	fmt.Fprintln(f)
             : }
How about adding a general helper function to write comments?

```suggestion
func Add_Comment(f *os.File, filetype Filetype, body string) {
    fmt.Fprintf(f, CommentFormatStrings[filetype], string)
}

func Add_gpl(f *os.File, filetype Filetype) {
    Add_Comment(f, filetype, "SPDX-License-Identifier: GPL-2.0-only")
    fmt.Fprintln(f)
}
```