[coreboot-gerrit] Change in coreboot[master]: soc/intel/elkhartlake/romstage: Do initial SoC commit till romstage

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44801 )

Change subject: soc/intel/elkhartlake/romstage: Do initial SoC commit till romstage
......................................................................

Patch Set 3: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/44801/3/src/soc/intel/elkhartlake/r... 
File src/soc/intel/elkhartlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/44801/3/src/soc/intel/elkhartlake/r... 
PS3, Line 28: void mainboard_memory_init_params(FSPM_UPD *mupd)
This function is not weak any more, should we get rid of this printk or at least change it?

https://review.coreboot.org/c/coreboot/+/44801/3/src/soc/intel/elkhartlake/r... 
File src/soc/intel/elkhartlake/romstage/romstage.c:

https://review.coreboot.org/c/coreboot/+/44801/3/src/soc/intel/elkhartlake/r... 
PS3, Line 26: Default weak implementation
This is not weak anymore...change the comment?