Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31370 )
Change subject: [WIP] console: Split loglevel for fast and slow ......................................................................
Patch Set 1:
(2 comments)
Ron, Julius: Let me know if this is something generally desireable. I can try some inlining to make it fit tegra210 bootblock (google/smaug failing build).
For Chrome OS I don't think we'd be interested in using this, but I don't mind you adding it if you want it. For the Tegra210 you can probably just shift the memory map around a bit (e.g. steal another KB from TIMESTAMP) to make it fit.
https://review.coreboot.org/#/c/31370/1/src/console/init.c File src/console/init.c:
https://review.coreboot.org/#/c/31370/1/src/console/init.c@73 PS1, Line 73: return 0; I think you may also want to return 0 here if CONFIG_CBMEM_CONSOLE is not enabled, so you don't waste time vtxprintf'ing all those messages if they don't get output anywhere.
https://review.coreboot.org/#/c/31370/1/src/console/printk.c File src/console/printk.c:
https://review.coreboot.org/#/c/31370/1/src/console/printk.c@34 PS1, Line 34: console_tx_byte(byte); Note that this seems to get called directly in some cases (looks like output from some old Intel MRCs?). Probably not worth fixing (I guess we don't want to call console_slowlog_level() for every single char), but maybe add a comment to point out this is an intentional shortcoming?