build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31810 )
Change subject: nb/amd/amdfam10: Remove redundant test if "BIOS_DEBUG" set ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/#/c/31810/2/src/northbridge/amd/amdfam10/setup_r... File src/northbridge/amd/amdfam10/setup_resource_map.c:
https://review.coreboot.org/#/c/31810/2/src/northbridge/amd/amdfam10/setup_r... PS2, Line 69: register_values[i+1] + ((register_values[i]==RES_PCI_IO) ? offset_pci_dev : 0), line over 96 characters
https://review.coreboot.org/#/c/31810/2/src/northbridge/amd/amdfam10/setup_r... PS2, Line 69: register_values[i+1] + ((register_values[i]==RES_PCI_IO) ? offset_pci_dev : 0), spaces required around that '==' (ctx:VxV)
https://review.coreboot.org/#/c/31810/2/src/northbridge/amd/amdfam10/setup_r... PS2, Line 71: register_values[i+3] + (((register_values[i] & RES_PORT_IO_32) == RES_PORT_IO_32) ? offset_io_base : 0) line over 96 characters
https://review.coreboot.org/#/c/31810/2/src/northbridge/amd/amdfam10/setup_r... PS2, Line 129: i/4, register_values[i],register_values[i+1], register_values[i+2], register_values[i+3]); line over 96 characters
https://review.coreboot.org/#/c/31810/2/src/northbridge/amd/amdfam10/setup_r... PS2, Line 129: i/4, register_values[i],register_values[i+1], register_values[i+2], register_values[i+3]); space required after that ',' (ctx:VxV)