Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31851 )
Change subject: mb/google/hatch: Provide DRAM part number from EEPROM
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/31851/6/src/mainboard/google/hatch/romstage....
File src/mainboard/google/hatch/romstage.c:
https://review.coreboot.org/#/c/31851/6/src/mainboard/google/hatch/romstage....
PS6, Line 58: *len = strlen(part_num_store);
Does this get padded out in the other parts of the stack? Or do we need to +1 ?
It ends up being passed to strncpy which would not pad it since we are passing in strlen. But, the dest to which it is being copied is memset to 0. So, ideally it should be good. But, I have done a +1 anyways in latest patchset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31851
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ade6999828b6d67aa78d04199138f195a97ba8c
Gerrit-Change-Number: 31851
Gerrit-PatchSet: 7
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 13 Mar 2019 01:52:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment