[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/apollolake: Fix FSP SATA speed limit configuraion

[Felix Singer (Code Review)]

Attention is currently required from: Mario Scheithauer, Sean Rhodes, Werner Zeh.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75820?usp=email )

Change subject: soc/intel/apollolake: Fix FSP SATA speed limit configuraion
......................................................................

Patch Set 7:

(3 comments)

Patchset:

PS7: 
Is there anything on which the SATA speed depends on or what could limit it?

File src/soc/intel/apollolake/ahci.c:

https://review.coreboot.org/c/coreboot/+/75820/comment/11040ce8_865b1a1a :
PS7, Line 12: 	if (speed == SATA_DEFAULT)
            : 		
nit: I wouldn't care about default values and just write the bits in any case.

File src/soc/intel/apollolake/include/soc/ahci.h:

https://review.coreboot.org/c/coreboot/+/75820/comment/f62be4b8_9d93031b :
PS7, Line 11: 0x00F00000
make it lowercase