Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36011 )
Change subject: soc/mediatek/mt8183: Improve code formatting
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
nit.
https://review.coreboot.org/c/coreboot/+/36011/5/src/soc/mediatek/mt8183/dra...
File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/36011/5/src/soc/mediatek/mt8183/dra...
PS5, Line 96: dramc_show
since there's a dramc_show of all results, I think this can be dramc_debug as well (and ODTN).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36011
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33616e6142325920c2fd7e6dc1dc88eb29c5cf34
Gerrit-Change-Number: 36011
Gerrit-PatchSet: 5
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Oct 2019 01:58:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment