Attention is currently required from: Michał Żygowski. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63500 )
Change subject: soc/intel/alderlake: Unselect USB4 and TCSS options for ADL-S ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/63500/comment/a58ecbe6_c5eeb9cf PS2, Line 101: select SOC_INTEL_COMMON_BLOCK_TCSS if !SOC_INTEL_ALDERLAKE_PCH_S : select SOC_INTEL_COMMON_BLOCK_THERMAL_BEHIND_PMC : select SOC_INTEL_COMMON_BLOCK_USB4 if !SOC_INTEL_ALDERLAKE_PCH_S : select SOC_INTEL_COMMON_BLOCK_USB4_PCIE if !SOC_INTEL_ALDERLAKE_PCH_S : select SOC_INTEL_COMMON_BLOCK_USB4_XHCI if !SOC_INTEL_ALDERLAKE_PCH_S Should we make a new Kconfig for these like
``` config SOC_INTEL_ALDERLAKE_TCSS_USB4_SUPPORT default y if !SOC_INTEL_ALDERLAKE_PCH_S default n if SOC_INTEL_ALDERLAKE_PCH_S select SOC_INTEL_COMMON_BLOCK_TCSS select SOC_INTEL_COMMON_BLOCK_USB4 select SOC_INTEL_COMMON_BLOCK_USB4_PCIE select SOC_INTEL_COMMON_BLOCK_USB4_XHCI ```
then `ramstage-$(CONFIG_SOC_INTEL_ALDERLAKE_TCSS_USB4_SUPPORT) += retimer.c`