Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57782 )
Change subject: soc/amd/*: Enable ACPIMMIO decode first in fch_pre_init
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
this is missing the corresponding change for stoneyridge
File src/soc/amd/picasso/early_fch.c:
https://review.coreboot.org/c/coreboot/+/57782/comment/7f14fa30_5275bb7f
PS3, Line 45: /* Enable_acpimmio_decode_pm04 to enable the ACPIMMIO decode which is needed to access
: the GPIO registers required for eSPI setup. */
the eSPI setup isn't the only thing that needs this, but i find that the comment suggest that this is only or at least primarily for the eSPI GPIO setup
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57782
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bc076261c72cf999a5f2464b74cff6bf694d473
Gerrit-Change-Number: 57782
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 12 Oct 2021 12:13:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment