Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid
......................................................................
Patch Set 66:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt:
https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte...
PS66, Line 4: ,3
: K4AAG165WA-BCWE,4
: MT40A1G16KD-062E:E,5
Because it was requested. Please see bug.
These parts are being requested for next build. You can just let the tool assign the IDs for the new parts and let the ODM know what IDs to use. The only reason we have used fixed IDs for parts 0,1,2 is to maintain backward compatibility with last build. Can you please drop the fixed IDs and provide the updated table to ODM to use for the next build.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44272
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66
Gerrit-Change-Number: 44272
Gerrit-PatchSet: 66
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mice Lin
mice_lin@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 28 Aug 2020 17:05:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment