Attention is currently required from: Cliff Huang, David Ruth, Lance Zhao, Subrata Banik, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80170?usp=email )
Change subject: Add MTCL function to ACPI SSDT tables ......................................................................
Patch Set 3:
(4 comments)
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/80170/comment/d724e822_17889a4c : PS3, Line 4788: nit: tab may be
File src/include/mtcl.h:
https://review.coreboot.org/c/coreboot/+/80170/comment/0f0ffaab_76cb887a : PS3, Line 1: #ifndef _MTCL_H_ nit: keep this as header for the new file
``` /* SPDX-License-Identifier: GPL-2.0-only */ ```
File src/vendorcode/google/chromeos/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/80170/comment/4c0dfde2_196ba0f8 : PS3, Line 11: ramstage-$(CONFIG_USE_MTCL) += mtcl.c nit: before line 10
File src/vendorcode/google/chromeos/mtcl.c:
https://review.coreboot.org/c/coreboot/+/80170/comment/5d700499_fa80a18f : PS3, Line 1: #include <cbfs.h> keep this as the first line\
``` /* SPDX-License-Identifier: GPL-2.0-only */ ```