Fred Reitberger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63025 )
Change subject: soc/amd/cezanne/cpu.c: Skip SMMINFO init in S3 resume ......................................................................
soc/amd/cezanne/cpu.c: Skip SMMINFO init in S3 resume
SMMINFO is already setup in S5, so it should be skipped in S3 resume
BUG=b:194990818 TEST=Build guybrush
Change-Id: I30ee6d7006ddac4dbdae9825bd4fa6eac7fd48cb Signed-off-by: Fred Reitberger reitbergerfred@gmail.com --- M src/soc/amd/cezanne/cpu.c 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/63025/1
diff --git a/src/soc/amd/cezanne/cpu.c b/src/soc/amd/cezanne/cpu.c index adc99d0..13db61f 100644 --- a/src/soc/amd/cezanne/cpu.c +++ b/src/soc/amd/cezanne/cpu.c @@ -11,6 +11,7 @@ #include <cpu/x86/mp.h> #include <cpu/x86/mtrr.h> #include <cpu/x86/smm.h> +#include <acpi/acpi.h> #include <device/device.h> #include <soc/cpu.h> #include <soc/iomap.h> @@ -37,7 +38,8 @@ static void post_mp_init(void) { global_smi_enable(); - apm_control(APM_CNT_SMMINFO); + if (!acpi_is_wakeup_s3()) // SMMINFO was already setup in S5 + apm_control(APM_CNT_SMMINFO); }
static const struct mp_ops mp_ops = {