Hello Nico Huber, Matt DeVillier, Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/libgfxinit/+/42364
to look at the new patch set (#2).
Change subject: gfxtest: Fix build failure with newer toolchain ......................................................................
gfxtest: Fix build failure with newer toolchain
Looks like there's a new warning that requires us to have the same ordering in both a record definition and its memory layout definition. This is not the case on the `Pixel_Type` record in gfxtest, so gfxtest would not build with the GNAT 10.1.0 toolchain because of the warning.
Since we define colors using positional notation, reordering the fields will result in the wrong colors being displayed. Account for that with the `Pixel_RGBA` inline function, which simply reorders the components.
Tested on Asus P8Z77-V LX2 with two displays, gfxtest is still dangerous for people with epilepsy. It does not look uglier than before, though.
Change-Id: Ic4b6cfd7f933ffaeeac389e45e211483d35fc6ac Signed-off-by: Angel Pons th3fanbus@gmail.com --- M gfxtest/hw-gfx-gma-gfx_test.adb 1 file changed, 11 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/64/42364/2