[coreboot-gerrit] [S] Change in coreboot[main]: src/device: Add more condition to check valid PCI device id

[Subrata Banik (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Jamie Ryu, Jeremy Compostella, Pratikkumar V Prajapati, Wonkyu Kim.

Subrata Banik has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84228?usp=email )

Change subject: src/device: Add more condition to check valid PCI device id
......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84228/comment/e0c32183_d1190450?usp... :
PS2, Line 12: Below are invalid PCI device id cases
            : VID: 0x0 or 0xffff
            : DID: 0x0 or 0xffff
> my 2 cents: This patch is just making coreboot more robust. Also this is a simple check, does not create any harm.

are you saying coreboot can now deal well with buggy HW ? if yes, then we should add such check in many places as well. I don't see a point to adding more code in FW rather ensure the HW can minimum maintain the sanity like VID and DID proper.