Attention is currently required from: Jason Glenesk, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56273 )
Change subject: soc/amd/picasso: add missing banks to mca_bank_name array
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/picasso/mca.c:
https://review.coreboot.org/c/coreboot/+/56273/comment/86120075_481856af
PS1, Line 138: [ 0] = "Load-store unit",
i'd say that moving the additional space from here to between the ] and the = doesn't make it look better...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56273
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10a65210da73e64b67d613609fcc0f9a245a81fb
Gerrit-Change-Number: 56273
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Tue, 13 Jul 2021 21:55:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment