Attention is currently required from: Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46949 )
Change subject: soc/intel/broadwell: Use Haswell CPU headers
......................................................................
Patch Set 15:
(1 comment)
File src/cpu/intel/haswell/haswell.h:
https://review.coreboot.org/c/coreboot/+/46949/comment/74ba2773_f5dcd776
PS15, Line 173: /* CPU identification */
: static inline u32 cpu_family_model(void)
: {
: return cpuid_eax(1) & 0x0fff0ff0;
: }
:
: static inline u32 cpu_stepping(void)
: {
: return cpuid_eax(1) & 0xf;
: }
Not a fan of these non-haswell specific things here.
I would move them to cpu/intel/common but these may not work for model F CPUs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46949
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If07e5272f07edb59bb18eef1f80d7d5807b26e66
Gerrit-Change-Number: 46949
Gerrit-PatchSet: 15
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 22 Jan 2021 20:15:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment