Attention is currently required from: Christian Walter, Lean Sheng Tan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63464 )
Change subject: mb/prodrive/atlas: Update KConfig ......................................................................
Patch Set 4:
(3 comments)
File src/mainboard/prodrive/atlas/Kconfig:
https://review.coreboot.org/c/coreboot/+/63464/comment/8bcb8e9b_dbb3c8fe PS2, Line 5: select DRIVERS_I2C_GENERIC : select DRIVERS_INTEL_DPTF : select DRIVERS_SPI_ACPI : select DRIVERS_USB_ACPI
Yes actually all of these have been enabled in devicetree: […]
But the chip drivers aren't used. For `DRIVERS_USB_ACPI`, the devicetree should have something like this:
device ref xhci on chip drivers/usb/acpi register "desc" = ""Root Hub"" register "type" = "UPC_TYPE_HUB" device ref xhci_root_hub on chip drivers/usb/acpi register "desc" = ""Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" device ref usb2_port10 on end end end end end
But I don't see any `chip drivers/usb/acpi` or similar in Atlas' devicetree.
https://review.coreboot.org/c/coreboot/+/63464/comment/20cd12a1_7f2397d9 PS2, Line 9: select DRIVERS_UART_8250IO
Because the current main debug UART we are using now is the EC UART. […]
Ah, I see. I guess no setup is required because the EC autoconfigures the UART's I/O base address to 0x3f8, is my guess correct?
https://review.coreboot.org/c/coreboot/+/63464/comment/c9d87604_855e67e5 PS2, Line 17: : config IGNORE_IASL_MISSING_DEPENDENCY : def_bool y
This is the common problem with IASL error for all ADL platforms.
Hmmm, looks like it's a problem with ChromeOS ASL. When building for ADLRVP-P with Intel EC, this is not a problem.