Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37568
to look at the new patch set (#2).
Change subject: [WIP] mb/acer: Add Acer E5-573 mainboard ......................................................................
[WIP] mb/acer: Add Acer E5-573 mainboard
Boots to Linux, things still very WIP.
The `acer_e5-573.dfc` file is the defconfig I have used. Using master with CB:37553 and CB:37568 (this change), this produces a coreboot.rom that can boot Arch Linux with on-disk GRUB. While the whole thing is more or less usable (I am typing this commit message on this laptop with coreboot, a bunch of things are still completely broken...
Tested and known to be working:
- At least one SATA port - USB ports - PCIe ports of the Ethernet and Wi-Fi NICs - Fan is spinning - Internal eDP display with libgfxinit - Display backlight on Linux with intel_backlight - Audio from speakers - UART 0 TXD for coreboot logs (wired to pin 4 of the VGA port, lol) - Memory initialization with two DIMMs - SMBus to read DIMM SPDs - Internal PS/2 keyboard - Internal flashing
Tested and known to be broken:
- PCIe port 1c.3 spams dmesg with AER errors about timeouts. - Too many PCIe ports are enabled. - Touchpad is dead. - Internal keyboard might be missing some ACPI devices. Linux has problems to detect it. - Poweroff takes a looooong time. - Function keys are dead: brightness, volume, Fn+Fx... However, the "media" keys (play, pause, previous, next) do work fine. - Looks like the MRC retrains all the time. Maybe it is not saving training data at all. - The EC firmware is shared with the main flash. Currently, it is very easy to overwrite it by accident and have a brick. It is probably at the beginning of the BIOS region, like other ITE ECs. - Pressing Num Lock makes weird things happen. *presses Num Lock* *ress5ng N40 36c2 0a2es we5rd th5ngs ha**en. **resses N40 36c2* - The fan is working. ALWAYS. IT SOUNDS LIKE A JET ENGINE. - The battery is working, but no ACPI device for it exists, so it's like the lottery. Remember to save your work! - ACPI lid device is probably missing.
Not tested:
- S3 resume. Likely broken. - Headphones jack. Need to double-check these Azalia spells. - Other payloads. - Windows. - Webcam. It probably works, but is covered with electrical tape. - Mike the microphone. - xHCI devices on the USB 3.0 ports. - Need to fine-tune HSIO PHYs. THE ULTIMATE SYMPHONY! - Making the thing boot off LPC.
Change-Id: I3ae188ee1dcbb6dfcf825eabdc31c041095aab13 Signed-off-by: Angel Pons th3fanbus@gmail.com --- A acer_e5-573.dfc A src/mainboard/acer/e5-573/Kconfig A src/mainboard/acer/e5-573/Kconfig.name A src/mainboard/acer/e5-573/Makefile.inc A src/mainboard/acer/e5-573/acpi/ec.asl A src/mainboard/acer/e5-573/acpi/mainboard.asl A src/mainboard/acer/e5-573/acpi/superio.asl A src/mainboard/acer/e5-573/acpi_tables.c A src/mainboard/acer/e5-573/board_info.txt A src/mainboard/acer/e5-573/devicetree.cb A src/mainboard/acer/e5-573/dsdt.asl A src/mainboard/acer/e5-573/early_init.c A src/mainboard/acer/e5-573/fadt.c A src/mainboard/acer/e5-573/gma-mainboard.ads A src/mainboard/acer/e5-573/gpio.c A src/mainboard/acer/e5-573/hda_verb.c A src/mainboard/acer/e5-573/mainboard.c A src/mainboard/acer/e5-573/pei_data.c A src/mainboard/acer/e5-573/romstage.c M src/superio/Makefile.inc 20 files changed, 650 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/37568/2