EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48111/7/src/mainboard/google/brya/c...
File src/mainboard/google/brya/chromeos.c:
https://review.coreboot.org/c/coreboot/+/48111/7/src/mainboard/google/brya/c...
PS7, Line 15: };
note to us: once the GPIO table is straightened out, we need EC_IN_RW here too
Got it:)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48111
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5311879a127a2c8da1bbb086449019d932d57b72
Gerrit-Change-Number: 48111
Gerrit-PatchSet: 8
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Fri, 04 Dec 2020 03:08:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment