[coreboot-gerrit] [XS] Change in coreboot[main]: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67

[Angel Pons (Code Review)]

Attention is currently required from: Elyes Haouas, Pratikkumar V Prajapati.

Angel Pons has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83110?usp=email )

Change subject: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67
......................................................................

Patch Set 1:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83110/comment/39e2d9e8_d50c2556?usp... :
PS1, Line 9: bh67bl
Did you mean `DH67BL`?

https://review.coreboot.org/c/coreboot/+/83110/comment/57566d8d_78ccd60c?usp... :
PS1, Line 11: ./inteltool -l
Do we need the inteltool output in the commit message?

File util/inteltool/lpc.c:

https://review.coreboot.org/c/coreboot/+/83110/comment/34bd6a41_bd2c8acb?usp... :
PS1, Line 90: 	case PCI_DEVICE_ID_INTEL_H67:
Why not add at least the rest of CPT IDs?

https://review.coreboot.org/c/coreboot/+/83110/comment/07c43960_23ed1512?usp... :
PS1, Line 120: 		bc = pci_read_long(dev, SUNRISE_LPC_BC);
Does this actually exist on CPT? I would prefer to have a special case for older platforms that only support LPC, just like the rest of the codebase does.