Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41348 )
Change subject: soc/intel/xeon_sp/cpx: display UPDs and CPX-SP specific HOBs ......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41348/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41348/16//COMMIT_MSG@9 PS16, Line 9: Support display of CPX-SP specific HOBs, and UPD parameters. Maybe:
This dumps the CPX-SP specific HOBs, and UPD parameters to the console.
Does this add anything to the boot time?
Maybe add a log excerpt.
https://review.coreboot.org/c/coreboot/+/41348/16//COMMIT_MSG@10 PS16, Line 10: Please mention, that UPD is only logged, if CONFIG_DISPLAY_UPD_DATA is selected.
https://review.coreboot.org/c/coreboot/+/41348/16/src/soc/intel/xeon_sp/cpx/... File src/soc/intel/xeon_sp/cpx/hob_display.c:
https://review.coreboot.org/c/coreboot/+/41348/16/src/soc/intel/xeon_sp/cpx/... PS16, Line 123: int unsigned int