Attention is currently required from: Alper Nebi Yasak, Julius Werner, Philipp Hug, ron minnich.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80372?usp=email )
Change subject: arch/io.h: Add stubs for x86 I/O port functions to other arches
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80372/comment/81299059_0de95b58 :
PS3, Line 19: We could cover every port function call with #if CONFIG(ARCH_X86), but
: that gets very cluttery. And it looks like it might be possible to
: somehow access to I/O ports over MMIO, as far as I can tell from U-Boot
: and Linux code.
The hardware often has a translator. Can you add that information as a TODO comment in the code?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80372?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If7d9177283e8c692088ba8e30d6dfe52623c8cb9
Gerrit-Change-Number: 80372
Gerrit-PatchSet: 3
Gerrit-Owner: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 07 Feb 2024 15:03:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment