[coreboot-gerrit] Change in coreboot[master]: util/amdfwtool: Grow the Embedded Firmware Structure

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35667 )

Change subject: util/amdfwtool: Grow the Embedded Firmware Structure
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35667/2/util/amdfwtool/amdfwtool.c 
File util/amdfwtool/amdfwtool.c:

https://review.coreboot.org/c/coreboot/+/35667/2/util/amdfwtool/amdfwtool.c@... 
PS2, Line 391: 0x4f
> Why so much reserved? Is there expectation to fill it up? If not, would it not be preferable 0x3f, m […]

This is simply defining the extent to which the PSP spec defines the structure.  This change isn't fixing any existing problem because there's already some padding introduced.  However, it ensures we won't attempt to accidentally put something immediately following bios1_entry in violation of what the PSP expects.