[coreboot-gerrit] Change in coreboot[master]: intel/ibexpeak boards: Remove handled RCBA entries from replay

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35440 )

Change subject: intel/ibexpeak boards: Remove handled RCBA entries from replay
......................................................................

Patch Set 11: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/35440/11/src/mainboard/lenovo/x201/... 
File src/mainboard/lenovo/x201/romstage.c:

https://review.coreboot.org/c/coreboot/+/35440/11/src/mainboard/lenovo/x201/... 
PS11, Line 73: 0xdeaddeed
lol

https://review.coreboot.org/c/coreboot/+/35440/11/src/mainboard/lenovo/x201/... 
PS11, Line 71:  (1 << 5) | (1 << 6) | (1 << 7) | (1 << 8) | (1 << 9)
             : 		| (1 << 10) | (1 << 11) | (1 << 12) | (1 << 28) | 1;
1. What's bit 28? the comment doesn't mention it.

2. Do we need so many shifts?

RCBA32(FD) = (0xff << 5) | (1 << 28) | 1;