Attention is currently required from: Derek Huang, Paul Menzel, Shou-Chieh Hsu, Tarun Tuli.
Leo Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75403?usp=email )
Change subject: mb/google/nissa/var/pujjo: Set GPIO of WWAN_SAR_DETECT to NC
......................................................................
Patch Set 7:
(2 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/75403/comment/c9026cce_246580f3 :
PS1, Line 9: Pujjo not support GPIO based D-SAR,
: so set GPP_D15 and GPP_H23 to NC.
*does not* (without *does* it would have fit in one line, that means 72 characters), now it’s still […]
Done
https://review.coreboot.org/c/coreboot/+/75403/comment/194e9cb9_79ae06b8 :
PS1, Line 13: TEST=Build and boot on pujjo
What does work now, that didn’t before?
Because Pujjo does not support GPIO based D-SAR, so remove GPIO setting and check WWAN dynamic SAR function is working.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75403?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4fe40b32a572a8d914e01e5cd7927766ccf17c02
Gerrit-Change-Number: 75403
Gerrit-PatchSet: 7
Gerrit-Owner: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-CC: Jynn Chen
jynn.chen@lcfc.corp-partner.google.com
Gerrit-CC: Kevin3 Yang
kevin3.yang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Wed, 14 Jun 2023 05:41:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment