Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75902?usp=email )
Change subject: acpi/acpi.c: Change signature of write_acpi_tables ......................................................................
acpi/acpi.c: Change signature of write_acpi_tables
The argument is copied into current and is never modified.
Signed-off-by: Arthur Heymans arthur@aheymans.xyz Change-Id: I3084e43ccbe9749bc726af3120decfe8b52e1709 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75902 Reviewed-by: Lean Sheng Tan sheng.tan@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: Lean Sheng Tan: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 78135d7..ce14538 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1854,7 +1854,7 @@ printk(BIOS_SPEW, "\n"); }
-unsigned long write_acpi_tables(unsigned long start) +unsigned long write_acpi_tables(const unsigned long start) { unsigned long current; acpi_rsdp_t *rsdp; diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 09e1211..d3f209a 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -1335,7 +1335,7 @@
/* These are implemented by the target port or north/southbridge. */ void preload_acpi_dsdt(void); -unsigned long write_acpi_tables(unsigned long addr); +unsigned long write_acpi_tables(const unsigned long addr); unsigned long acpi_fill_madt(unsigned long current);
void acpi_fill_fadt(acpi_fadt_t *fadt);