Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25759 )
Change subject: mb/google/poppy/atlas: Enable trackpad
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/25759/1/src/mainboard/google/poppy/variants/...
File src/mainboard/google/poppy/variants/atlas/devicetree.cb:
https://review.coreboot.org/#/c/25759/1/src/mainboard/google/poppy/variants/...
PS1, Line 256: register "wake" = "GPE0_DWx_19" not possible?
Is the trackpad_int# routed to two SoC GPIOs? I don't see it in the gpio.c file.
--
To view, visit
https://review.coreboot.org/25759
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4a82aa605ec68fd38e52c13406eaf803f9e86cc
Gerrit-Change-Number: 25759
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali
caveh@google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-Comment-Date: Sat, 21 Apr 2018 12:27:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes