Attention is currently required from: Raul Rangel, Andrey Petrov, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58987 )
Change subject: drivers/intel/fsp2_0: Add preload_fspm and preload_fsps ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58987/comment/a1a1bb70_0fa475ed PS2, Line 8: : FSP is normally memmapped and then decompressed. nit: this is only true in the non-XIP world, it cannot be decompressed "in-place" on Intel platforms.
File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/58987/comment/cfb1bf1d_ec7f9067 PS2, Line 349: nit: extra blank line
File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/58987/comment/ef61c93e_54c2b635 PS2, Line 239: same