Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31913 )
Change subject: soc/intel/common/../pcie: Fix 'unsigned int' to bare use of 'unsigned'
......................................................................
Patch Set 1:
The change is correct, but when you come across these please fix the entire tree with one bulk run. Eventually someone has to do that, it would be nice if not all of that was upto volunteering contributors.
And for this particular set_subsystem(), maybe there is one standard case where one just writes these PCI config registers without any locking involved; that one should be promoted to globally available function and the dozens(?) of copies removed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31913
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee09b601045d7785a0977a4f7ed7385b1d311044
Gerrit-Change-Number: 31913
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 15 Mar 2019 17:20:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment