8 Nov
2022
8 Nov
'22
7:52 p.m.
Attention is currently required from: Arthur Heymans, Robert Zieba, Nico Huber, Angel Pons, Martin Roth, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67931 )
Change subject: cpu/x86/smm: Add PCI BAR store functionality ......................................................................
Patch Set 7:
(1 comment)
File src/include/cpu/x86/smm.h:
https://review.coreboot.org/c/coreboot/+/67931/comment/d0321da1_06e116e8 PS5, Line 225: smm_runtime
I'm fine with either approach, but this way allows the SMM init code to call this function without h […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/67931
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23fb1e935dd1b89f1cc5c834cc2025f0fe5fda37
Gerrit-Change-Number: 67931
Gerrit-PatchSet: 7
Gerrit-Owner: Robert Zieba robertzieba@google.com
Gerrit-Reviewer: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: Robert Zieba robertzieba@google.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 08 Nov 2022 17:52:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Robert Zieba robertzieba@google.com
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Gerrit-MessageType: comment