Attention is currently required from: Martin Roth, Paul Menzel, Ron Minnich, HAOUAS Elyes. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50966 )
Change subject: Documentation/coding_style: Issues not mentioned and cleanup patches ......................................................................
Patch Set 2:
(1 comment)
File Documentation/contributing/coding_style.md:
https://review.coreboot.org/c/coreboot/+/50966/comment/c45deea1_ccbddce7 PS2, Line 27: positives. They should not be bulk-applied to change existing code.)
To bulk-apply clang-format is exactly what would eliminate the discussions around style...
Yeah and it also turns our code into an unreadable mess.
Now as far as I understand the use of clang-format is not mandatory in coreboot at this point, so I would ask to please defer any discussions about doing anything new with clang-format that we are currently not doing to the mailing list. I'm just suggesting some general principles about how we should treat other people's existing code in this patch, and picking examples based on our currently mandatory style to illustrate them. If that style changes in the future of course the examples may change with it.