Attention is currently required from: Tim Wawrzynczak, Eric Lai.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63562 )
Change subject: mb/google/brya/baseboard/nissa: Configure I2C lcnt and hcnt
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63562/comment/0cd5fb15_5ab8c43d
PS2, Line 9: Configure lcnt and hcnt directly to give the required frequency, tHIGH
Thanks, I wasn't aware that this was a consideration. […]
When the ODM measured the frequencies they varied from about 387 to 399 on the different buses, but this was only measuring a few cycles. We just measured a large number of cycles and the average is around 390 kHz, so it should be fine. I've updated the commit message to mention this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63562
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d4f877c1f0cd9aacd3fa152890b7ef82e059f78
Gerrit-Change-Number: 63562
Gerrit-PatchSet: 3
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Reka Norman
rekanorman@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 12 Apr 2022 06:22:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment