Attention is currently required from: Martin Roth, Furquan Shaikh, Marshall Dawson, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56644 )
Change subject: util/amdtools: Add script to update the SPI speed in the EFS header ......................................................................
Patch Set 2:
(9 comments)
File util/amdtools/update_efs_spi_speed:
https://review.coreboot.org/c/coreboot/+/56644/comment/15588054_8c6bba18 PS2, Line 4: $1 quotes
https://review.coreboot.org/c/coreboot/+/56644/comment/89990873_335e0dcb PS2, Line 5: NEW_SPEED You could do `declare -i NEW_SPEED="$2"`. This will convert the value into an integer.
https://review.coreboot.org/c/coreboot/+/56644/comment/25dc2675_6e1187c5 PS2, Line 5: $2 quotes
https://review.coreboot.org/c/coreboot/+/56644/comment/70748d2d_acdd714b PS2, Line 25: ${NEW_SPEED} quotes
https://review.coreboot.org/c/coreboot/+/56644/comment/31a7e6b0_34a0401d PS2, Line 25: ${ROM} Quotes
https://review.coreboot.org/c/coreboot/+/56644/comment/3017596d_bfa2f26c PS2, Line 56: dd "of=${ROM}" bs=1 "seek=${location}" "count=${length}" conv=notrunc 2>/dev/null `dd .. < <(printf "$hexval")`
This way the if condition will fail if dd fails.
https://review.coreboot.org/c/coreboot/+/56644/comment/3a3f0fdf_4d4203ef PS2, Line 56: 2>/dev/null does adding `status=none` work instead? Seeing the error might be helpful if the rom was readonly.
https://review.coreboot.org/c/coreboot/+/56644/comment/190c5c33_ed96b6d9 PS2, Line 109: $(getval "${location}" "4") quotes
https://review.coreboot.org/c/coreboot/+/56644/comment/1c853ae5_029b7b5a PS2, Line 112: ${location} quotes