Attention is currently required from: Martin Roth, Martin L Roth, Subrata Banik, Sridhar Siricilla.
Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71646 )
Change subject: soc/intel/common: Use CPUID_STRUCT_EXTENDED_FEATURE_FLAGS macro
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
i think creating another inline wrapper for cpuid_ext() for getting CPU Ext feature capabilities would be overkill. So i just used the macro. If community folks want a dedicated inline wrapper i can create something like this..
inline struct cpuid_result get_cpu_ext_cap( const uint32_t ecx)){
return cpuid_ext(CPUID_STRUCT_EXTENDED_FEATURE_FLAGS, ecx);
}
let me know!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71646
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If680ffff64e2e1dabded8c03c4042d349a11b635
Gerrit-Change-Number: 71646
Gerrit-PatchSet: 1
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 04 Jan 2023 02:37:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment