Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31140
Change subject: lib/hardwaremain: Remove unused acpi_is_wakeup() function ......................................................................
lib/hardwaremain: Remove unused acpi_is_wakeup() function
Looks like acpi_is_wakeup() return value is not getting honoured, hence this function is not doing anything rather reading from romstage buffer.
Change-Id: Icc57804074a58315e72e276fcae799febc10612d Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/lib/hardwaremain.c 1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/31140/1
diff --git a/src/lib/hardwaremain.c b/src/lib/hardwaremain.c index 98b8841..3ec7e8e 100644 --- a/src/lib/hardwaremain.c +++ b/src/lib/hardwaremain.c @@ -2,6 +2,7 @@ * This file is part of the coreboot project. * * Copyright (C) 2013 Google, Inc. + * Copyright (C) 2019 Intel Inc. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -469,11 +470,6 @@ timestamp_add_now(TS_START_RAMSTAGE); post_code(POST_ENTRY_RAMSTAGE);
- /* Handoff sleep type from romstage. */ -#if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME) - acpi_is_wakeup(); -#endif - exception_init(); threads_initialize();