[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/mt8196: Add booker driver

[Yidi Lin (Code Review)]

Attention is currently required from: Dehui Sun, Hung-Te Lin, Jarried Lin, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85362?usp=email )

Change subject: soc/mediatek/mt8196: Add booker driver
......................................................................

Patch Set 3:

(1 comment)

File src/soc/mediatek/mt8196/booker.c:

https://review.coreboot.org/c/coreboot/+/85362/comment/5f4185d8_655c1fe6?usp... :
PS1, Line 23: 	"ldr	x0, =0x0a450a00\n"
            : 	"ldr	x1, [x0]\n"
            : 	"ldr	x2, =0x8\n"
            : 	"bic	x1, x1, x2\n"
            : 	"str	x1, [x0]\n"
            : 
            : 	"ldr	x0, =0x0ac50a00\n"
            : 	"ldr	x1, [x0]\n"
            : 	"ldr	x2, =0x8\n"
            : 	"bic	x1, x1, x2\n"
            : 	"str	x1, [x0]\n"
            : 
            : 	"ldr	x0, =0x0b450a00\n"
            : 	"ldr	x1, [x0]\n"
            : 	"ldr	x2, =0x8\n"
            : 	"bic	x1, x1, x2\n"
            : 	"str	x1, [x0]\n"
            : 
            : 	"ldr	x0, =0x0bc50a00\n"
            : 	"ldr	x1, [x0]\n"
            : 	"ldr	x2, =0x8\n"
            : 	"bic	x1, x1, x2\n"
            : 	"str	x1, [x0]\n"
> This inline assembly involves general flow settings. […]

Thanks. Using `clrbits32` would be clear and readable.