Attention is currently required from: Furquan Shaikh, Henry Sun, Paul Menzel, Tao Xia, Karthikeyan Ramasubramanian.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54249 )
Change subject: mb/google/dedede/var/blipper: Configure I2C times for touchpad/touchpanel/codec
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/dedede/variants/blipper/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/54249/comment/865598d6_64eb4929
PS2, Line 24: .speed_config[0] = {
: .speed = I2C_SPEED_FAST,
: .scl_lcnt = 190,
: .scl_hcnt = 100,
: .sda_hold = 40,
: }
Please configure the measured rise and fall time here instead of lcnt and hcnt. Same for all the i2c buses below.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54249
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8438e37be49f8a74f53fd8460110dac1a3f06993
Gerrit-Change-Number: 54249
Gerrit-PatchSet: 2
Gerrit-Owner: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ginger Zhang
zhangqingchun@huaqin.corp-partner.google.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-CC: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Comment-Date: Tue, 18 May 2021 18:36:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment