Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44270 )
Change subject: soc/intel/jasperlake: Disable IPU based on devicetree ......................................................................
Patch Set 2: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/44270/2/src/soc/intel/jasperlake/ro... File src/soc/intel/jasperlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/44270/2/src/soc/intel/jasperlake/ro... PS2, Line 73: m_cfg->SaIpuEnable = 0;
or m_cfg->SaIpuEnable = is_dev_enabled(dev);
That is much better.