Attention is currently required from: Michael Niewöhner, Karthik Ramasubramanian. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49411 )
Change subject: mb/google/octopus: do LPC/eSPI pad configuration at board-level ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49411/comment/055458e5_4d7fb9e3 PS1, Line 9: other platforms Which other platforms? I couldn't find any variant_early_bootblock_gpio_table().
File src/mainboard/google/octopus/bootblock.c:
https://review.coreboot.org/c/coreboot/+/49411/comment/51668e76_9aa6851e PS1, Line 13: pads = variant_early_bootblock_gpio_table(&num); The default contents are specific to make the next variant-independent step mainboard_ec_init() work. So why allow a variant override, i.e. why make it weak?
File src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/49411/comment/7991d68c_874c000c PS1, Line 15: const struct pad_config *variant_early_bootblock_gpio_table(size_t *num); : const struct pad_config *variant_early_gpio_table(size_t *num); The name `early_bootblock` made me think that `early` is not done in the bootblock. Can we find better names?