[coreboot-gerrit] Change in coreboot[master]: security/vboot: Add vboot callbacks to support EC software sync

[Joel Kitching (Code Review)]

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36208 )

Change subject: security/vboot: Add vboot callbacks to support EC software sync
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36208/2/src/security/vboot/sync_ec.... 
File src/security/vboot/sync_ec.c:

https://review.coreboot.org/c/coreboot/+/36208/2/src/security/vboot/sync_ec.... 
PS2, Line 50: vboot_sync_ec
> Understood, is persistent context implemented yet?

Not yet.

https://review.coreboot.org/c/coreboot/+/36208/2/src/security/vboot/sync_ec.... 
PS2, Line 64: 	memcpy(ctx.workbuf, (void *)p, wd->buffer_size);
> The workbuffer *has* to be the same across all calls to vboot, otherwise all sorts of things inside  […]

See bug for timeline.