Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46626 )
Change subject: soc/mediatek/mt8183: Fix pq module size config ......................................................................
Patch Set 2: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/46626/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46626/1//COMMIT_MSG@8 PS1, Line 8:
The bug description is much the same as the this commit message.
The description here is more for "how", not "what" (problem).
Usually we want to describe what and how, for example
soc/mediatek/mt8183: Fix incorrect display on large panels
[brief intro for when/how that issue is reproduced]
[brief description on how to fix it]
I know you found this when tracing the details in ddp implementation, but can you figure out some potential issue that may generate failure if this is not fixed?
For example how PQ will be used, or how this may make things wrong if H/V sizes are large/small?